From 7ca966a8ad4120deb89a6087d2e088e715f7dff3 Mon Sep 17 00:00:00 2001
From: RoboMagus <68224306+RoboMagus@users.noreply.github.com>
Date: Tue, 14 Dec 2021 11:39:29 +0100
Subject: [PATCH] Docker mod for installing Subversion + SVN extension into
 code-server container.

---
 .github/workflows/BuildImage.yml           |  2 +-
 README.md                                  | 12 +++++-------
 root/etc/cont-init.d/98-subversion         |  6 ++++++
 root/etc/cont-init.d/99-install-extensions | 15 ---------------
 root/etc/cont-init.d/99-svn-extension      |  4 ++++
 5 files changed, 16 insertions(+), 23 deletions(-)
 create mode 100644 root/etc/cont-init.d/98-subversion
 delete mode 100644 root/etc/cont-init.d/99-install-extensions
 create mode 100644 root/etc/cont-init.d/99-svn-extension

diff --git a/.github/workflows/BuildImage.yml b/.github/workflows/BuildImage.yml
index 0e0fe38..8316ec8 100644
--- a/.github/workflows/BuildImage.yml
+++ b/.github/workflows/BuildImage.yml
@@ -5,7 +5,7 @@ on: [push, pull_request, workflow_dispatch]
 env:
   ENDPOINT: "linuxserver/mods" #don't modify
   BASEIMAGE: "code-server" #replace
-  MODNAME: "extension-arguments" #replace
+  MODNAME: "svn" #replace
 
 jobs:
   build:
diff --git a/README.md b/README.md
index 51d0c36..4553221 100644
--- a/README.md
+++ b/README.md
@@ -1,9 +1,7 @@
-# Extension Arguments - Docker mod for code-server
+# SVN - Docker mod for code-server
 
-This mod installs code-server extensions at startup. The list of extensions to be installed should be provided using environment variable `VSCODE_EXTENSION_IDS` separated by `|`.
+This mod installs subversion and the SVN extension into code-server at startup.
 
-For example, to install the `vscode-docker` and `vscode-icons` extensions add the following lines to your docker compose service:
-```yaml
-- DOCKER_MODS=linuxserver/mods:code-server-docker|linuxserver/mods:code-server-extension-arguments
-- VSCODE_EXTENSION_IDS=vscode-icons-team.vscode-icons|ms-azuretools.vscode-docker
-```
+In code-server docker arguments, set an environment variable `DOCKER_MODS=linuxserver/mods:code-server-svn`
+
+If adding multiple mods, enter them in an array separated by `|`, such as `DOCKER_MODS=linuxserver/mods:code-server-python3|linuxserver/mods:code-server-svn`
diff --git a/root/etc/cont-init.d/98-subversion b/root/etc/cont-init.d/98-subversion
new file mode 100644
index 0000000..8549a44
--- /dev/null
+++ b/root/etc/cont-init.d/98-subversion
@@ -0,0 +1,6 @@
+#!/usr/bin/with-contenv bash
+
+apt-get update
+
+echo "**** installing subversion ****"
+apt-get install -y subversion
diff --git a/root/etc/cont-init.d/99-install-extensions b/root/etc/cont-init.d/99-install-extensions
deleted file mode 100644
index f733f05..0000000
--- a/root/etc/cont-init.d/99-install-extensions
+++ /dev/null
@@ -1,15 +0,0 @@
-#!/usr/bin/with-contenv bash
-
-# Exit if no VsCode extensions are given
-if [ -z ${VSCODE_EXTENSION_IDS+x} ]; then
-  echo "**** No VSCODE EXTENSIONS GIVEN****"
-  exit 0
-fi
-
-
-IFS='|'
-VSCODE_EXTENSION_IDS=(${VSCODE_EXTENSION_IDS})
-for ID in "${VSCODE_EXTENSION_IDS[@]}"; do
-    echo "**** installing extension: ${ID} ****"
-    code-server --user-data-dir /config/data --extensions-dir /config/extensions --install-extension ${ID}
-done
\ No newline at end of file
diff --git a/root/etc/cont-init.d/99-svn-extension b/root/etc/cont-init.d/99-svn-extension
new file mode 100644
index 0000000..6237e76
--- /dev/null
+++ b/root/etc/cont-init.d/99-svn-extension
@@ -0,0 +1,4 @@
+#!/usr/bin/with-contenv bash
+
+echo "**** installing SVN extension ****"
+s6-setuidgid abc code-server --user-data-dir /config/data --extensions-dir /config/extensions --install-extension johnstoncode.svn-scm
\ No newline at end of file